fix(v4): the identity gate's final review, items 1-4
From the fresh whole-branch review of the identity gate (With fixes; no Critical, four Important): 1. A drive pulled while a line ran: the drives are looked at before every prompt (sk_v4_identity_check_now), so no prompt is shown once she is gone and what was typed after the pull does not run as Zuse. 2. Pulled while a line WAITS: the wait is ended at logout, by an empty line, and not carried into her next session (Captain Bob, 2026-10-26: "end the waiting line at logout"); re-attaching brings the prompt back. 3. EMERGENCY_CONSOLE_ENABLED: v4 honours it as v3 does -- a bring-up build has a prompt with no drive (boards/BRINGUP.md A2). 4. Keys typed at a headless machine are read and dropped, not run as whoever logs in next. (v3 has the same gap, sk_repl_headless_wait; reported, not changed.) Each a QEMU session red then green (amd64): midpull 111650 -> 112953, waitpull 111907 -> 113154, emergency 112524 -> 113609, typeahead 112248 -> 113359; headless 113800 and hotplug 114043 still pass. Accepted: three clean qemu boots to [zuse@Hera] ok>, POST 538/538, dict_hash 0xfec8c47cfc6f437f on all three; hotplug on aarch64 and riscv64; make -C v4 test test-32 sanitize hosted-check EXIT 0; make -C v4 test-32 0 failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
668abc48e6
commit
6452c540a2
@@ -191,10 +191,26 @@ void sk_v4_identity_beat(void)
|
||||
}
|
||||
}
|
||||
|
||||
void sk_v4_identity_check_now(void)
|
||||
{
|
||||
g_last_beat = heartbeat_ticks();
|
||||
sk_v4_idle();
|
||||
}
|
||||
|
||||
/* What was typed at a headless machine is no one's: it is read and dropped,
|
||||
* so that it does not run as whoever logs in next (the identity gate's
|
||||
* final review, item 4, 2026-10-26). */
|
||||
static void sk_v4_discard_input(void)
|
||||
{
|
||||
while (console_getc() >= 0) { }
|
||||
}
|
||||
|
||||
void sk_v4_identity_wait(void)
|
||||
{
|
||||
while (!g_zuse_session) {
|
||||
sk_v4_discard_input();
|
||||
sk_v4_identity_beat();
|
||||
arch_relax();
|
||||
}
|
||||
sk_v4_discard_input();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user