fe25519_carry shifts a negative carry left (fe25519.c:31, and :35), undefined in C99; CI's signed capsules reach it in san-mesh-boot. Reported, not fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RzZgrf7V7Zk2iczBXDRbm
17 lines
1004 B
Plaintext
17 lines
1004 B
Plaintext
The nightly's v4-checks failure of 2026-11-20 (run 333, job 923, on master fdf9c194), reproduced
|
|
without the capsule-signing key.
|
|
|
|
CI: san-mesh-boot: kernel/src/crypto/fe25519.c:31:26: runtime error: left shift of negative value -1
|
|
Here: repro.c, built with the sanitize gate's flags (-O1 -fsanitize=address,undefined
|
|
-fno-sanitize-recover=all) against kernel/src/crypto/fe25519.c alone: run.txt, the same line.
|
|
|
|
Cause: fe25519_carry computes c = v[i] >> 51 and then v[i] -= c << 51. After fe25519_sub, a limb is
|
|
negative, c is -1, and a left shift of a negative value is undefined in C99. The comment says the
|
|
code "works for negative limbs too (arithmetic shift preserves sign)", which holds for the right
|
|
shift, not the left. Line 35 (limb 4) has the same form.
|
|
|
|
Why locally the sanitize gate passes: with no signing key the capsules are unsigned, and the mesh
|
|
boot never verifies an Ed25519 signature, so this code does not run there. CI has the key.
|
|
|
|
Not fixed (reported to Captain Bob).
|